Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor statusbar #5514

Merged
merged 14 commits into from Oct 20, 2018
Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Oct 18, 2018

Finishes #5352. This is a big restructuring of the status bar extension to be more idiomatic and in line with the rest of the core codebase.

  1. Breaks the statusbar extension into two packages, statusbar and statusbar-extension.
  2. Removes the IDefaultsManager. This was mostly redundant with the actual IStatusBar interface, and I found it pretty confusing. Extension authors should add status items using the IStatusBar. One downside of this is that the IDefaultsManager handled some logic about enabling and disabling status items via the settings registry. We may want to revisit that, but at the moment all of the status items are individual plugins, so they can be disabled at the application level.
  3. Moves several of the status bar items to other packages, where appropriate. For instance, the notebook trust status item is moved to the notebook-extension. Several of the status items that are more cross-cutting in their application remain in the statusbar-extension.
  4. Removes and simplifies various things.
  5. Adds a lot of docstrings.
@ian-r-rose ian-r-rose force-pushed the refactor-statusbar branch from 8d87385 to cd634af Oct 18, 2018
@ian-r-rose ian-r-rose force-pushed the refactor-statusbar branch from cd634af to 3ec2fe3 Oct 19, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 20, 2018

Still WIP?

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Oct 20, 2018

Yeah, I think so. It's an improvement right now, but I still want to hack at it a bit.

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Oct 20, 2018

Though I suppose we could merge and iterate, since this would be a painful rebase...

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 20, 2018

👍 for iteration

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Oct 20, 2018

Okay, merge away then!

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 20, 2018

Done, thanks!

@blink1073 blink1073 merged commit 334136f into jupyterlab:master Oct 20, 2018
2 checks passed
@ian-r-rose ian-r-rose added this to the 1.0 milestone Oct 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants