Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix override url #5518

Merged
merged 4 commits into from Oct 29, 2018
Merged

Fix override url #5518

merged 4 commits into from Oct 29, 2018

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 19, 2018

Follow up to #5503

@blink1073 blink1073 added this to the 0.35.x milestone Oct 19, 2018
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Oct 19, 2018

cc @eoinmurray. I tested this locally by running python -m http.server from the static folder and running: jupyter lab --LabApp.override_static_url='http://0.0.0.0:8000/' --dev-mode

@eoinmurray
Copy link

@eoinmurray eoinmurray commented Oct 19, 2018

Great, having a look now

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Oct 19, 2018

Do you mean you're trying locally?

@eoinmurray
Copy link

@eoinmurray eoinmurray commented Oct 28, 2018

@blink1073 Is dev-mode required for this to work?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Oct 28, 2018

Yes, until we cut a new release with it

@eoinmurray
Copy link

@eoinmurray eoinmurray commented Oct 28, 2018

Ah ok sure, seems to work well for me, I think its then just a matter of taking the dev_mode/static folder and hosting on s3 and then using cloudfront to host those files, when the release is done.

I think this is a good solution as the vendors~main file can get quite large, especially with extensions installed, any idea when the release might come?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Oct 28, 2018

I'll cut a release later today

@blink1073 blink1073 merged commit 1256377 into jupyterlab:master Oct 29, 2018
2 checks passed
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Oct 29, 2018

0.35.3 is now on PyPI

@eoinmurray
Copy link

@eoinmurray eoinmurray commented Oct 29, 2018

Even with that release, its not working without the --dev-mode flag

@eoinmurray
Copy link

@eoinmurray eoinmurray commented Oct 29, 2018

jupyter lab --LabApp.override_static_url='http://0.0.0.0:8000/' and python -m http.server in the static dir, but it still tries to fetch from http://localhost:8888/lab/static/vendors~main.aeebdbd4a5d862502cba.js, not at :8000

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Oct 30, 2018

Yikes, this one is a bear... I might not get a chance to look at it again until the weekend.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Nov 3, 2018

I had botched something in the backport. I confirmed that the override works with 0.35.4. Cheers!

@eoinmurray
Copy link

@eoinmurray eoinmurray commented Nov 30, 2018

@blink1073 thanks for the help and working on this!, we've implemented it a kyso minifying frontend assets and serving with Cloudfront and we ended up with a great first load experience.

@jasongrout jasongrout removed this from the 0.35.x milestone Feb 2, 2019
@jasongrout jasongrout added this to the 1.0 milestone Feb 2, 2019
@blink1073 blink1073 deleted the fix-override-url branch Jun 2, 2019
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants