Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More statusbar cleanup #5525

Merged
merged 21 commits into from Oct 26, 2018
Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Oct 25, 2018

Continuing #5352. Overall, this is mostly restructuring and cleaning up, with very little functionality change. It is, however, a lot of restructuring in an attempt to be more idiomatic.

  • Adds docstrings.
  • Removes unused code. Despite a large number of docstrings, this is a net-negative line diff.
  • More restructuring and shuffling of things into a more modular/decoupled setup. Status item components are in the most relevant package. Plugins providing those components are in ${package}-extension.
  • Several bugfixes.
  • One breaking change: the tabs-vs-spaces status item no longer applies to notebooks: I found the user-interface to be pretty confusing and a bit buggy. It was a major simplification to only target file editors, the same as the settings menu does. These settings can still be set via the advanced settings editor.
@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Oct 26, 2018

Okay, this is ready for a look. I still want to do a few things, but probably in a follow-up.

TODO:

  1. Add a bunch of statusbar tests.
  2. There are a couple of dependencies that I am still not happy about. Think about how to break them.
  3. Consider having the statusbar themed.

@ian-r-rose ian-r-rose changed the title [WIP] More statusbar cleanup More statusbar cleanup Oct 26, 2018
Copy link
Member

@blink1073 blink1073 left a comment

Wow, that is quite a bit of plumbing, nicely done!

@blink1073 blink1073 merged commit b2619f4 into jupyterlab:master Oct 26, 2018
2 checks passed
@ian-r-rose ian-r-rose added this to the 1.0 milestone Oct 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants