Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text drag drop #5571

Merged
merged 3 commits into from Nov 2, 2018
Merged

Text drag drop #5571

merged 3 commits into from Nov 2, 2018

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Nov 2, 2018

Adds a drop handler for plain text in the abstract editor widget.
This is a necessary step for drag/drop of code snippets (cf. some discussion in #2020).
Along the way this fixes #3732.

Screenshots
drag-drop

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Nov 2, 2018

This is truly fantastic!!!

@bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Nov 2, 2018

Copy link
Member

@blink1073 blink1073 left a comment

Very nice, thanks!

@blink1073 blink1073 merged commit a904d01 into jupyterlab:master Nov 2, 2018
1 of 2 checks passed
@betteridiot
Copy link

@betteridiot betteridiot commented Nov 2, 2018

That is awesome...never thought my feature request would be implemented. Thank you

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants