Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The statusbar strikes back #5577

Merged
merged 13 commits into from Nov 3, 2018

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Nov 2, 2018

Finishes #5352.

  • Missed a spot in the #5525 for moving the filebrowser upload-status-item to the filebrowser package.
  • More docstrings and cleanup.
  • Simplify some internals for the StatusBar widget.
  • Add a test suite for the core statusbar widget. Individual components remain untested, but the core API is at least there.
  • Updates the application dependency graph. I'm not wild about some of the dependencies, but I don't think they are the fault of the statusbar. In particular, I think too many things rely on @jupyterlab/codemirror, especially the application rendermime. In that instance, CodeMirror is used to provide syntax highlighting for rendered code blocks. We could try to factor that out into an abstracted functionality provided by the rendermime-extension. On the other hand, it makes the application rendermime less useful out-of-the-box, so maybe I am overthinking it.
@blink1073
Copy link
Member

@blink1073 blink1073 commented Nov 2, 2018

Best PR title ever.

Loading

Copy link
Member

@blink1073 blink1073 left a comment

Looks great, thanks!

Loading

@blink1073 blink1073 merged commit 0fad407 into jupyterlab:master Nov 3, 2018
2 checks passed
Loading
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants