Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autosave interval setting. #5645

Merged
merged 3 commits into from Nov 27, 2018
Merged

Conversation

@johnkmzhou
Copy link
Contributor

@johnkmzhou johnkmzhou commented Nov 19, 2018

Fixes #5619 with help from @davidccole.

Copy link
Member

@ian-r-rose ian-r-rose left a comment

Thanks @johnkmzhou and @davidccole, this is looking great! It is currently missing one piece, and then we should be good to go: currently new context created by the docmanager do not have their save interval set, and so they remain at 120 seconds. We should also set that save interval at creation time (roughly at line 460 in manager.ts, where it is determined whether to start the save handler).

Copy link
Member

@ian-r-rose ian-r-rose left a comment

Thanks!

@ian-r-rose ian-r-rose merged commit dc126c3 into jupyterlab:master Nov 27, 2018
2 checks passed
@jasongrout jasongrout added this to the 1.0 milestone Feb 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants