Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sort extension search alphabetically #5649

Merged
merged 1 commit into from Nov 21, 2018
Merged

Don't sort extension search alphabetically #5649

merged 1 commit into from Nov 21, 2018

Conversation

@vidartf
Copy link
Member

@vidartf vidartf commented Nov 19, 2018

Sorting the extensions alphabetically will artificially give more visibility to packages early in the alphabet. Instead, retain the sort order from the registry, which is based on a composite score including:

Sorting the extensions alphabetically gives more visibility to packages early in the alphabet. Instead, retain the sort order from the registry, which is based on a composite score including:
- How well the package matches the search text.
- A package "score": https://docs.npmjs.com/searching-for-and-choosing-packages-to-download#package-search-rank-criteria
@vidartf
Copy link
Member Author

@vidartf vidartf commented Nov 19, 2018

Alternatively, this can instead only sort the
"Jupyter-brand extensions" alphabetically.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Nov 19, 2018

+1 to keeping the registry score for now, if that seems good.

@blink1073 blink1073 added this to the 1.0 milestone Nov 20, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Nov 21, 2018

Thanks!

@blink1073 blink1073 merged commit 1d09ecf into master Nov 21, 2018
1 of 4 checks passed
@vidartf vidartf deleted the vidartf-patch-1 branch Nov 21, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants