Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styles for description lists (dl, dt, dd) to be consistent with nteract #5682

Merged
merged 2 commits into from Nov 29, 2018

Conversation

@gnestor
Copy link
Contributor

@gnestor gnestor commented Nov 27, 2018

Closes #2399

This also adds the HTML CSS class names to VDOM output so that HTML rendered with VDOM is styled consistently with HTML output.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Nov 27, 2018

Thanks! Can you add before/after screenshots?

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Nov 28, 2018

Before:

image

After:

image

@ellisonbg ellisonbg self-assigned this Nov 29, 2018
@saulshanabrook saulshanabrook merged commit 4efe8c7 into jupyterlab:master Nov 29, 2018
1 of 3 checks passed
@jasongrout jasongrout added this to the 1.0 milestone Feb 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants