Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow file path between file browser and editor #5698

Merged
merged 3 commits into from Dec 19, 2018

Conversation

@gnestor
Copy link
Contributor

@gnestor gnestor commented Nov 29, 2018

Fixes #4258

This adds the File Browser to the Settings and introduces a "navigateToCurrentDirectory" option that, when enabled, will navigate the file browser to the CWD (current working directory) of the current document.

image

@timkpaine
Copy link
Member

@timkpaine timkpaine commented Nov 29, 2018

nice!!!

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Dec 5, 2018

I tested this locally and the behavior is fantastic! This will really help in situations for users have a large number of files open across many different directories. I think for now it is fine to have this configurable in the advanced settings system, however I would love to see a menu item under the settings menu to enable users to change this more easily.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Dec 10, 2018

@gnestor This looks great from my perspective. Could you rebase to resolve the merge conflict?

@gnestor gnestor force-pushed the navigate-to-cwd branch from 6c3c012 to ca0f4aa Dec 10, 2018
@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Dec 10, 2018

@ian-r-rose Done!

@ellisonbg Should I add an item to the changelog describing this feature and how to enable it?

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Dec 19, 2018

Thanks!

@ian-r-rose ian-r-rose merged commit 8b606ca into jupyterlab:master Dec 19, 2018
3 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants