Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefixes for loaders #5709

Merged
merged 1 commit into from Dec 10, 2018
Merged

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Nov 30, 2018

Fixes #4406 in favor of using the !raw-loader syntax to specify loaders.

Copy link
Member

@saulshanabrook saulshanabrook left a comment

Looks good!

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 1, 2018

Just checking, can we do the equivalent of the url-loader?limit=10000 rule with the exclamation syntax?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Dec 3, 2018

Yes, according to the webpack docs on inline loaders, "options can be passed with a query parameter".

@blink1073 blink1073 merged commit bc05b6c into jupyterlab:master Dec 10, 2018
2 of 3 checks passed
@blink1073 blink1073 deleted the remove-loader-prefix branch Jun 2, 2019
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants