Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of commands to keyboard shortcut description. #5812

Merged
merged 1 commit into from Jan 26, 2019

Conversation

@afshin
Copy link
Member

@afshin afshin commented Dec 28, 2018

Add list of commands to keyboard shortcut description in transformed schema. Fixes #5562

list of commands screenshot

@afshin afshin added this to the 1.0 milestone Dec 28, 2018
@afshin afshin self-assigned this Dec 28, 2018
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 29, 2018

The list of commands is quite long, right? Do you mind if we put it at the end then, so people can get to the actual shortcuts much more quickly?

@afshin
Copy link
Member Author

@afshin afshin commented Dec 29, 2018

@jasongrout This is just taking advantage of rendering the title and description fields in the schema transform. I'm not sure how to put the comments at the end.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 30, 2018

I'm not sure how to put the comments at the end.

Okay. I agree it's better at the front than not at all.

@ellisonbg ellisonbg self-requested a review Jan 2, 2019
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jan 8, 2019

I also agree that it is better than nothing. Eventually this could be added to the shortcuts UI.

Copy link
Member

@saulshanabrook saulshanabrook left a comment

Tried this locally and works great!

@saulshanabrook saulshanabrook merged commit 6d7c769 into jupyterlab:master Jan 26, 2019
3 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants