Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep autoscroll behavior when clearing cell output. #5817

Merged
merged 1 commit into from Jan 26, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 30, 2018

Fixes #4028

CC @ellisonbg, @saulshanabrook

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Dec 30, 2018

  • Change "Enable/Disable" scrolling to a single command that is toggleable (with a checkmark)? Then a keyboard shortcut can just toggle between the states, rather than having two different commands that enable/disable.

This gets tricky when multiple cells are selected. In that case, toggle status could be indeterminate.

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jan 18, 2019

If someone wants to take this PR up and finish it, please feel free to do so (comment here so that we know someone is working on it...)

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jan 26, 2019

* Change "Enable/Disable" scrolling to a single command that is toggleable (with a checkmark)? Then a keyboard shortcut can just toggle between the states, rather than having two different commands that enable/disable.

Let's make this a separate issue.

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jan 26, 2019

This seems to work as intended.

I tried enabling scrolling for outputs then clearing them, and they were still scrolled after re executing.

@saulshanabrook saulshanabrook merged commit 8f06ac0 into jupyterlab:master Jan 26, 2019
2 of 3 checks passed
@jasongrout jasongrout changed the title [WIP] Keep autoscroll behavior when clearing cell output. Keep autoscroll behavior when clearing cell output. Jan 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants