Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insertBefore and insertAfter to Toolbar #5896

Merged
merged 2 commits into from Jan 24, 2019
Merged

Conversation

@ntdef
Copy link
Contributor

@ntdef ntdef commented Jan 22, 2019

Resolves #5894

@ntdef
Copy link
Contributor Author

@ntdef ntdef commented Jan 22, 2019

Seems like the CI build failed for reasons unrelated to the PR (404 from docs?).

Copy link
Member

@ian-r-rose ian-r-rose left a comment

Thanks @ntdef! This looks great. I see one copy-paste error in the docstrings, but otherwise I think this looks good-to-go.

You are right that the test-failures seem unrelated.

packages/apputils/src/toolbar.tsx Show resolved Hide resolved
packages/apputils/src/toolbar.tsx Outdated Show resolved Hide resolved
packages/apputils/src/toolbar.tsx Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ntdef ntdef left a comment

Resolved comments in latest commit.

packages/apputils/src/toolbar.tsx Outdated Show resolved Hide resolved
packages/apputils/src/toolbar.tsx Outdated Show resolved Hide resolved
@ian-r-rose ian-r-rose added this to the 1.0 milestone Jan 24, 2019
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jan 24, 2019

Thanks @ntdef!

@ian-r-rose ian-r-rose merged commit f948692 into jupyterlab:master Jan 24, 2019
2 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants