Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vars to themes in order to support larger fonts #5898

Merged
merged 2 commits into from Jan 26, 2019

Conversation

@telamonian
Copy link
Member

@telamonian telamonian commented Jan 23, 2019

I recently made a theme that uses a code font that's slightly larger than the default (I think Consolas looks best in 15px). In addition to the font size, I also had to change a whole bunch of hard coded spacing and padding variables to match the larger font size. Most of these are already exposed as variables in the theme css, but the variables controlling the scaling of the code cursor were not.

This pull request exposes the code cursor widths as css variables, and moves them in to the themes. Without these vars, the cursor was too skinny and hard to see.

@telamonian telamonian changed the title Added more css vars to themes to support larger fonts in themes Added vars to themes to in order to support larger fonts Jan 23, 2019
@telamonian telamonian changed the title Added vars to themes to in order to support larger fonts Added vars to themes in order to support larger fonts Jan 23, 2019
Copy link
Member

@ian-r-rose ian-r-rose left a comment

Sounds reasonable to me. Thanks @telamonian

@ian-r-rose ian-r-rose merged commit 208fa74 into jupyterlab:master Jan 26, 2019
2 of 3 checks passed
@jasongrout jasongrout added this to the 1.0 milestone Feb 2, 2019
@rhsmits91
Copy link

@rhsmits91 rhsmits91 commented Apr 10, 2019

this has made my cursor invisible on 100% zoom (that is no zoom) on any of the resolutions & on any browser tried (IE, Chrome (latest), Chromium, Edge, FireFox)

is there a way of putting a minimum width in? Or a way to change these variables --jp-code-cursor-width0 values?

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 10, 2019

Thanks for opening #6179. Let's carry the discussion forward there.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants