Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added vars to themes in order to support larger fonts #5898

Merged
merged 2 commits into from Jan 26, 2019
Merged

Added vars to themes in order to support larger fonts #5898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14ed9ec
added more css vars to themes to support larger fonts
telamonian Jan 23, 2019
c371da2
removed cruft
telamonian Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/codemirror/style/index.css
View file
Open in desktop
Expand Up @@ -60,20 +60,22 @@
}

.jp-CodeMirrorEditor[data-type='inline'] .CodeMirror-cursor {
border-left: 1.4px solid var(--jp-editor-cursor-color);
border-left: var(--jp-code-cursor-width0) solid var(--jp-editor-cursor-color);
}

/* When zoomed out 67% and 33% on a screen of 1440 width x 900 height */
@media screen and (min-width: 2138px) and (max-width: 4319px) {
.jp-CodeMirrorEditor[data-type='inline'] .CodeMirror-cursor {
border-left: 2px solid var(--jp-editor-cursor-color);
border-left: var(--jp-code-cursor-width1) solid
var(--jp-editor-cursor-color);
}
}

/* When zoomed out less than 33% */
@media screen and (min-width: 4320px) {
.jp-CodeMirrorEditor[data-type='inline'] .CodeMirror-cursor {
border-left: 4px solid var(--jp-editor-cursor-color);
border-left: var(--jp-code-cursor-width2) solid
var(--jp-editor-cursor-color);
}
}

Expand Down
5 changes: 5 additions & 0 deletions packages/theme-dark-extension/style/variables.css
View file
Open in desktop
Expand Up @@ -188,6 +188,11 @@ all of MD as it is not optimized for dense, information rich UIs.
/* This gives a magnification of about 125% in presentation mode over normal. */
--jp-code-presentation-font-size: 16px;

/* may need to tweak cursor width if you change font size */
--jp-code-cursor-width0: 1.4px;
--jp-code-cursor-width1: 2px;
--jp-code-cursor-width2: 4px;

/* Layout
*
* The following are the main layout colors use in JupyterLab. In a light
Expand Down
5 changes: 5 additions & 0 deletions packages/theme-light-extension/style/variables.css
View file
Open in desktop
Expand Up @@ -186,6 +186,11 @@ all of MD as it is not optimized for dense, information rich UIs.
/* This gives a magnification of about 125% in presentation mode over normal. */
--jp-code-presentation-font-size: 16px;

/* may need to tweak cursor width if you change font size */
--jp-code-cursor-width0: 1.4px;
--jp-code-cursor-width1: 2px;
--jp-code-cursor-width2: 4px;

/* Layout
*
* The following are the main layout colors use in JupyterLab. In a light
Expand Down