Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands to open the main menus so that they may be assigned keyboard shortcuts. #5910

Merged
merged 3 commits into from Jan 26, 2019

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jan 25, 2019

Fixes #3074.

I have not assigned a default keyboard shortcut for these, but this allows the user to assign shortcuts in order to improve accessibility of the menus.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 25, 2019

Can we add one more command to Open first menu (whatever that might be)? That way we can have a single accessibility keyboard shortcut to open the menu system, no matter what menu might be first.

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Jan 25, 2019

Sure, sounds good.

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jan 26, 2019

I tested this locally and it works. I added this keyboard shortcut which opens the file menu:

{
    "shortcuts": [
        {
            "command": "mainmenu:open-first",
            "keys": ["Accel Shift F"],
            "selector": "body"
        }
    ]
}

@saulshanabrook saulshanabrook merged commit bc483f1 into jupyterlab:master Jan 26, 2019
2 of 3 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants