Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new terminal if connecting to an old one fails. #5917

Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jan 29, 2019

This makes starting a new terminal a bit more fault-tolerant. It fixes a bug that can be reproduced by the following:

  1. Launch a new terminal.
  2. Close the terminal session from the running panel without closing the terminal panel.
  3. Refresh the page -- the terminal widget will fail to restore.

Now, the above description is not a huge deal, but the broken restoration also makes workspace files that are less portable: if you try to launch from an existing workspace (e.g., on binder), terminals will not restart because they try to connect to a nonexistent session and fail.

@ian-r-rose ian-r-rose added this to the 1.0 milestone Jan 29, 2019
@ian-r-rose ian-r-rose changed the title Start a new terminal if connecting to an old one fails. [WIPStart a new terminal if connecting to an old one fails. Jan 29, 2019
@ian-r-rose ian-r-rose changed the title [WIPStart a new terminal if connecting to an old one fails. [WIP] Start a new terminal if connecting to an old one fails. Jan 29, 2019
@ian-r-rose ian-r-rose changed the title [WIP] Start a new terminal if connecting to an old one fails. Start a new terminal if connecting to an old one fails. Jan 29, 2019
@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Jan 29, 2019

A similar problem afflicted code consoles, for which I have also included a fix here.

@ian-r-rose ian-r-rose force-pushed the fault-tolerant-terminal-start branch from e68eae1 to 06ff93d Jan 29, 2019
@jasongrout jasongrout self-requested a review Jan 31, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 31, 2019

Thanks!

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 31, 2019

Unrelated test failure. Thanks!

@jasongrout jasongrout merged commit 0b527fa into jupyterlab:master Jan 31, 2019
0 of 3 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants