Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterFrontend cleanup #5919

Merged
merged 5 commits into from Jan 30, 2019
Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jan 30, 2019

Some falllout from #5845.

  • Threads opener into docmanager commands: tsc didn't catch this because window.opener exists.
  • Documentation links went out of date because APIs were changed and the old links broke the docs build.
  • Defensively check for whether setting editor has setting selected.
@afshin
Copy link
Member

@afshin afshin commented Jan 30, 2019

Oof. That's a good one. Thanks!

@afshin afshin changed the title IJupyterFrontend cleanup JupyterFrontend cleanup Jan 30, 2019
afshin
afshin approved these changes Jan 30, 2019
Copy link
Member

@afshin afshin left a comment

👍

@ian-r-rose ian-r-rose merged commit dd5243d into jupyterlab:master Jan 30, 2019
1 of 3 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants