Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workspaces list method to conform to IDataConnector list method. #5975

Merged
merged 3 commits into from Feb 19, 2019

Conversation

@afshin
Copy link
Member

@afshin afshin commented Feb 11, 2019

The list() method of the workspace service is updated to conform to the IDataConnector interface. While it is probably the case that nobody was using this method, since this is a backward-incompatible change, it requires a major version bump.

NB This PR has a hard dependency on jupyterlab/jupyterlab_server#61, which means its tests will fail until a new version of jupyterlab_server is published and the dependency is bumped in this branch.

@afshin afshin added this to the 1.0 milestone Feb 11, 2019
@afshin afshin self-assigned this Feb 11, 2019
@afshin afshin force-pushed the services-workspace-list branch from 0890f15 to 4732357 Feb 13, 2019
@afshin afshin changed the title Update workspaces list method to conform to IDataConnector list method. [WIP] Update workspaces list method to conform to IDataConnector list method. Feb 14, 2019
@afshin afshin force-pushed the services-workspace-list branch from 4732357 to 3b8d451 Feb 15, 2019
@afshin afshin changed the title [WIP] Update workspaces list method to conform to IDataConnector list method. Update workspaces list method to conform to IDataConnector list method. Feb 15, 2019
Copy link
Member

@ian-r-rose ian-r-rose left a comment

Looks good, thanks @afshin

@ian-r-rose ian-r-rose merged commit ae3bc12 into jupyterlab:master Feb 19, 2019
9 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants