Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase z-index of search overlay #6024

Merged
merged 1 commit into from Feb 24, 2019
Merged

Conversation

@aschlaep
Copy link
Member

@aschlaep aschlaep commented Feb 22, 2019

This bumps the z-index of the ctrl-f search overlay from 5 to 7. The CodeMirror horizontal scroll bar has a z-index of 6, so it was appearing on top of the search overlay.

Before:
search overlay obstructed

After:
search overlay in the clear

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Feb 22, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Feb 24, 2019

Thanks, this works great!

@jasongrout jasongrout merged commit b4a8cd3 into jupyterlab:master Feb 24, 2019
9 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants