Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an 'all' flag to uninstall all labextensions in the app-dir #6058

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@Madhu94
Copy link
Collaborator

@Madhu94 Madhu94 commented Mar 2, 2019

Fixes #6006

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Mar 2, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@vidartf
Copy link
Member

@vidartf vidartf commented Mar 4, 2019

The code itself LGTM, but it seems like some tests needs updating (jupyterlab.tests.test_jupyterlab.TestExtension).

@Madhu94
Copy link
Collaborator Author

@Madhu94 Madhu94 commented Mar 9, 2019

@vidartf I've added a test for --all

@vidartf
Copy link
Member

@vidartf vidartf commented Mar 10, 2019

@Madhu94 Are all the python tests passing locally for you? There seems to be some failures on the CI at least.

@Madhu94
Copy link
Collaborator Author

@Madhu94 Madhu94 commented Mar 10, 2019

@vidartf Thanks ! This was my mistake, I think I ran only the new test I added. I think the tests for the commands should be fixed now


def run_task(self):
self.extra_args = self.extra_args or [os.getcwd()]
return any([
uninstall_extension(arg, self.app_dir, logger=self.log)
uninstall_extension(arg, self.all, self.app_dir, logger=self.log)
Copy link
Member

@vidartf vidartf Mar 21, 2019

After changing the signature, this will now fail (and this part is not covered by the test). I think this is the final bit :)

Copy link
Collaborator Author

@Madhu94 Madhu94 Mar 21, 2019

Sorry about that again ! I'll be more careful. Made the arguments explicit and squashed the commits

@Madhu94 Madhu94 force-pushed the uninstall-all-extensions branch from 6e2d4f2 to e5a0abc Mar 21, 2019
@afshin afshin added this to the 1.0 milestone Mar 27, 2019
@afshin afshin requested a review from vidartf Mar 27, 2019
Copy link
Member

@vidartf vidartf left a comment

The code LGTM, and I gave it a quick test locally. I'm going to assume that the test failures are unrelated, and hit merge on this.

@vidartf vidartf merged commit 98ebe62 into jupyterlab:master Mar 28, 2019
6 of 9 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants