Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab navigation to the search box #6094

Merged
merged 3 commits into from Apr 2, 2019

Conversation

@aschlaep
Copy link
Member

@aschlaep aschlaep commented Mar 15, 2019

This adds a tab index to the entry and each button/toggle in the search box. Now you can navigate from the search input to any of the buttons using the tab key and activate them with enter. This also adds a box shadow to the buttons when you navigate to them via the keyboard (but not when you click on them). Lastly, this changes the cursor to the pointer on the buttons.

I couldn't really find any similar UX in JupyterLab but this seemed like it'd be useful. I started to do this in search & replace (#6081), where it will be necessary to move between the two boxes, but I figured it'd be worth putting in early and separate. Any suggestions on improving the CSS or the look of the box shadow would be much appreciated.

Gif demo using tab and shift+tab to navigate, enter to activate the buttons:
ctrl-f-tab-index

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Mar 15, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@lresende
Copy link
Member

@lresende lresende commented Mar 21, 2019

LGTM, I have tested the patch via the launch binder button and it all looks good. I will leave the request for suggestions on improving the CSS for others to comment.

@aschlaep
Copy link
Member Author

@aschlaep aschlaep commented Mar 22, 2019

Thanks @lresende! I've got some plans for making this look better, hoping to get those in early next week.

@afshin afshin requested a review from jasongrout Mar 27, 2019
@afshin afshin added this to the 1.0 milestone Mar 27, 2019
@aschlaep
Copy link
Member Author

@aschlaep aschlaep commented Mar 27, 2019

Looks much better now!
ctrl-f-tab-index2

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 2, 2019

Nice! I fixed one small thing in 7bc0ff1

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 2, 2019

The Windows JS is failing, but the Linux JS passed. The Windows JS test failed on the @jupyterlab/notebook, NotebookActions, #runAndAdvance(), should stop executing code cells on an error. The error was that it had a timeout of 30000ms.

@jasongrout jasongrout merged commit d7a8530 into jupyterlab:master Apr 2, 2019
7 of 9 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants