Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search match colors in notebook and text document #6155

Merged
merged 5 commits into from Apr 2, 2019

Conversation

@aschlaep
Copy link
Member

@aschlaep aschlaep commented Apr 1, 2019

This PR updates the highlight colors for search matches in notebooks and in text files (any searchable widget using CodeMirror). To get the extra highlighting, I had to turn on the styleSelectedText option by default. When this is turned on, CodeMirror applies a class, CodeMirror-selectedtext, to the selected section of text. I used this as well as the cm-searching class that gets applied to the text by the search mode to apply custom styling to the selected and unselected matches.

Light theme screenshot:
search_colors_light

Dark theme screenshot:
search_colors_dark

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Apr 1, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 1.0 milestone Apr 2, 2019
@jasongrout jasongrout self-requested a review Apr 2, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 2, 2019

Looks good to me. Thanks! Flagging the ux team for comments in the next day or two. Otherwise I'll merge and we can iterate on the design.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 2, 2019

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 2, 2019

We'll do a UX review before the final release, so I'll merge this to keep things progressing.

@jasongrout jasongrout merged commit 79a332d into jupyterlab:master Apr 2, 2019
7 of 9 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants