Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to enable the extension manager #6200

Merged
merged 8 commits into from May 21, 2019

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Apr 14, 2019

This adds the Enable Extension Manager command to the command palette and the main menu.

extension-manager-cmd

It can sometimes be a bit difficult to figure out how to enable the extension manager.
Having it exposed as a command should make it more accessible and simplify the steps listed in the docs.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Apr 14, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio
Copy link
Member Author

@jtpio jtpio commented Apr 14, 2019

Or maybe the plan for 1.0 is to enable it by default?

@afshin afshin requested a review from vidartf Apr 16, 2019
@afshin
Copy link
Member

@afshin afshin commented Apr 16, 2019

cc: @vidartf @tgeorgeux

I think because there isn't yet a story for what to do about extensions that are front-end + back-end, this feature is disabled by default. I don't have a problem with making it easier to discover, but maybe we should add the word "experimental" or something. What do Vidar and Tim think?

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Apr 18, 2019

The other reason this was a bit hidden was that we didn't want users to have to install node in order to install lab. So we wanted to hide it a bit until we at least had some feature-detection for node on the frontend.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 18, 2019

Also, there was still some concern about messaging to users that we do not vet these extensions in any way.

@jasongrout jasongrout added this to the 1.0 milestone Apr 22, 2019
@blink1073
Copy link
Member

@blink1073 blink1073 commented May 3, 2019

We already have a way to tell if node is available on the client:

if (builder.isAvailable && builder.shouldCheck) {

return PageConfig.getOption('buildAvailable').toLowerCase() === 'true';

I think with that check this PR should go in along with #6277 that solves the companion install piece.

@blink1073
Copy link
Member

@blink1073 blink1073 commented May 3, 2019

Agreed that it should still be disabled by default so we can hit the user with that warning dialog.

@jtpio
Copy link
Member Author

@jtpio jtpio commented May 13, 2019

@blink1073 the last commit (0b1a40d) checks if the builder is available, and disables the command otherwise:

image

@jtpio
Copy link
Member Author

@jtpio jtpio commented May 13, 2019

So now the current state is as follows:

  • the extension manager is disabled by default
  • the command to enable the extension manager is only enabled if the builder (node) is available
  • if the builder is available (node is installed), and the user decides to enable the extension manager, the warning popup (same as before) shows up and the extension manager can be enabled

Should we also add the word "experimental" (or similar) as @afshin suggested? For example: "Enable Extension Manager (experimental)"

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 13, 2019

Should we also add the word "experimental" (or similar) as @afshin suggested? For example: "Enable Extension Manager (experimental)"

+1. The more caveats the better at this stage, I think.

Copy link
Contributor

@jasongrout jasongrout left a comment

Thanks. This looks good to me now!

@aschlaep aschlaep merged commit 7c05352 into jupyterlab:master May 21, 2019
9 checks passed
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 21, 2019

Congrats on your first merge, @aschlaep!

@blink1073
Copy link
Member

@blink1073 blink1073 commented May 21, 2019

image

@jtpio jtpio deleted the toggle-ext-manager branch Jun 15, 2019
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants