Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix re-focus on ctrl+f when search overlay is already open #6241

Merged
merged 1 commit into from Apr 26, 2019

Conversation

@aschlaep
Copy link
Member

@aschlaep aschlaep commented Apr 24, 2019

This is a quick fix to the documentsearch package. Right now, pressing ctrl+f when your focus is in the document and the search box is already open does nothing. This fix refocuses the search box when you press ctrl+f again. This was broken in #6159.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Apr 24, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@aschlaep
Copy link
Member Author

@aschlaep aschlaep commented Apr 24, 2019

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Apr 26, 2019

Works great, thanks @aschlaep !

@ian-r-rose ian-r-rose added this to the 1.0 milestone Apr 26, 2019
@ian-r-rose ian-r-rose merged commit 10ac1a7 into jupyterlab:master Apr 26, 2019
9 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants