Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shutdown on close capability for terminals #6285

Merged
merged 1 commit into from May 1, 2019

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented Apr 30, 2019

References

Related issue: #5241
This is a follow-up of #6275 for terminals.

Code changes

Add option shutdownOnClose for ITerminal.IOptions.
If this is true, the session will be shut down when a terminal tab is closed.

User-facing changes

New settings:
Terminal -> Shut down on close

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Apr 30, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Looks good, thanks!

@blink1073 blink1073 merged commit 82cea06 into jupyterlab:master May 1, 2019
@blink1073 blink1073 added this to the 1.0 milestone May 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
@fcollonval fcollonval deleted the 5241-terminal-shutdown branch Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants