Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jp 6199 use json5 instead of comment json #6343

Conversation

rahulpshah
Copy link
Contributor

References

Fixes #6199

Code changes

Use json5 and update package.json

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

Thanks, @rahulnexus! Can you please try running jlpm at the repo root and then committing the change? It looks like you have a different version of yarn that is causing the huge line diff.

@jasongrout jasongrout added this to the 1.0 milestone May 13, 2019
@rahulpshah rahulpshah force-pushed the feature/JP-6199--use-json5-instead-of-comment-json branch from 9d4953d to c3c9d21 Compare May 14, 2019 02:31
@jasongrout
Copy link
Contributor

Thanks!

@jasongrout jasongrout merged commit b58e1dd into jupyterlab:master May 15, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use json5 for settings files
4 participants