Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous 'Find and Replace...' item from the edit menu and codemirror #6350

Merged

Conversation

@aschlaep
Copy link
Member

@aschlaep aschlaep commented May 14, 2019

References

Fixes #6322

Code changes

This removes the IFindReplacer interface and all findReplacers logic from the Edit menu. It also removes the Find and Replace command added by the CodeMirror extension. These are being removed in favor of the new interfaces provided by the documentsearch package.

User-facing changes

Removes the Find and Replace item from the edit menu in favor of the Find option which provides replace functionality as well.

Backwards-incompatible changes

This removes the findReplacers property from the editMenu. Extensions that would like to add Find or Find and Replace functionality should use the documentsearch package instead.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented May 14, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

@blink1073 blink1073 commented May 15, 2019

LGTM, thanks!

@blink1073 blink1073 merged commit b9f142d into jupyterlab:master May 15, 2019
9 checks passed
@blink1073 blink1073 added this to the 1.0 milestone May 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants