Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip collapsed cells when selecting #6356

Merged
merged 3 commits into from May 15, 2019
Merged

Conversation

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented May 15, 2019

  • Add test when there is no non-collapsed cell that selection stays the same
  • Change behavior to skip collapsed cells

References

Fixes #3233

Code changes

Update NotebookActions.selectBelow and NotebookActions.selectAbove to skip over collapsed cells.

User-facing changes

When the user is in edit mode, and the select a cell above or below, the selection changes to first non collapsed cell.

Backwards-incompatible changes

None.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented May 15, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Loading

@saulshanabrook saulshanabrook marked this pull request as ready for review May 15, 2019
@saulshanabrook saulshanabrook added this to the 1.0 milestone May 15, 2019
Copy link
Member

@blink1073 blink1073 left a comment

Nice, thanks!

Loading

@blink1073 blink1073 merged commit 223c63e into jupyterlab:master May 15, 2019
@saulshanabrook saulshanabrook deleted the collapsed branch May 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants