Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling down running sessions #6383

Merged
merged 1 commit into from May 22, 2019
Merged

Conversation

@manuzhang
Copy link
Contributor

@manuzhang manuzhang commented May 22, 2019

References

This fixes #6371

Code changes

Added overflow:auto to the jp-RunningSessions-section class as suggested by @jasongrout

User-facing changes

Before
image

After

image

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented May 22, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 1.0 milestone May 22, 2019
Copy link
Contributor

@jasongrout jasongrout left a comment

Thanks, this looks great to me. Merging after tests pass.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 22, 2019

The last remaining test failure is not related.

Thanks again, and congratulations on your first contribution!

@jasongrout jasongrout merged commit 3732d02 into jupyterlab:master May 22, 2019
7 of 9 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants