Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection lost token #6399

Merged
merged 9 commits into from May 24, 2019
Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented May 24, 2019

Provides a token for an action that can be taken when a connection to the server is lost. Fixes #6176. Re-fixes #3324, which had reverted.

References

#6176
#3324

Code changes

Adds some new connectionFailure signals to service manager classes. I only added them to the ones which poll the server, which is not all of them. It feels a little asymmetric, but I mostly wanted this signal to be the result of slower polling.

User-facing changes

No user-facing changes, except in the context of a JupyterHub deployment, where a different dialog may be provided.

Backwards-incompatible changes

Several service managers now have a new connectionFailure signal on their interfaces.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented May 24, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented May 24, 2019

Note: I have a fix I want to try to make in the filebrowser model, but was hoping to hold off on that until #6394 is resolved.

packages/application/src/router.ts Show resolved Hide resolved
packages/application/src/tokens.ts Show resolved Hide resolved
packages/application/src/tokens.ts Show resolved Hide resolved
packages/application-extension/src/index.tsx Outdated Show resolved Hide resolved
packages/application/src/connectionlost.ts Show resolved Hide resolved
packages/application/src/tokens.ts Show resolved Hide resolved
packages/services/src/manager.ts Show resolved Hide resolved
@ian-r-rose ian-r-rose force-pushed the connection-lost-token branch from 3ba3d22 to 1f9b34e May 24, 2019
@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented May 24, 2019

Okay, should be ready

Copy link
Member

@blink1073 blink1073 left a comment

LGTM, thanks!

@vidartf vidartf merged commit 4d1eeba into jupyterlab:master May 24, 2019
9 checks passed
@blink1073 blink1073 mentioned this pull request Jun 3, 2019
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants