Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the Last Modified column on a narrow filebrowser. #6406

Merged
merged 2 commits into from May 24, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 24, 2019

References

Fixes #6093

Code changes

Adds an onResize handler to the directory listing that toggles a class when the width is narrow. Additionally, the last modified column css hides itself when the directory listing is narrow.

User-facing changes

When the user narrows the filebrowser, the last modified column disappears.

Before

Minimal width:
Screen Shot 2019-05-24 at 11 27 16 AM

After

Just over 250px:
Screen Shot 2019-05-24 at 11 10 33 AM

Just under 250px wide:

Screen Shot 2019-05-24 at 11 10 24 AM

Minimum width filebrowser:
Screen Shot 2019-05-24 at 11 10 43 AM

Backwards-incompatible changes

None.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented May 24, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented May 24, 2019

Looks like a lint failure.

Copy link
Member

@ian-r-rose ian-r-rose left a comment

Beautiful!
resize

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented May 24, 2019

Approved by @ian-r-rose above. Tests pass (except an error @ian-r-rose and I decided was unrelated). Thanks!

@jasongrout jasongrout merged commit 77a940e into jupyterlab:master May 24, 2019
7 of 9 checks passed
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented May 24, 2019

Thanks @jasongrout!

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants