Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selected command palette darker on hover #6407

Merged
merged 1 commit into from May 24, 2019

Conversation

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented May 24, 2019

References

This fixes #279. In it @Carreau said:

I think that this might be because for selected item, the appearance is not different on :hover, and that having an extra-highlight or underline on hover will partly help my brain adjust and click only once.

Other next steps would be to:

  • Flash the command after it is activated so that the user knows they have activated it (#1095)
  • Debounce the click so that a double click doesn't trigger the command twice.

Code changes

None.

User-facing changes

Not hover selected (same as before):
Screen Shot 2019-05-24 at 3 55 10 PM

hover and selected (darker than before):
Screen Shot 2019-05-24 at 3 55 19 PM

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented May 24, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

LGTM, thanks!

@blink1073 blink1073 merged commit 42c32c1 into jupyterlab:master May 24, 2019
9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants