Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phosphor packages to restore tab drop zone #6454

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 1, 2019

This pulls in the tab drop zone change in @phosphor/widgets 1.7.0.

References

Fixes #5406

Code changes

Updates phosphor packages.

User-facing changes

See the updated tab drop behavior at phosphorjs/phosphor#365 (screenshots are there).

Backwards-incompatible changes

None

This pulls in the tab drop zone change in @phosphor/widgets 1.7.0.

Fixes jupyterlab#5406
@jasongrout jasongrout added this to the 1.0 milestone Jun 1, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 1, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout changed the title Update phosphor packages. Update phosphor packages to restore tab drop zone Jun 1, 2019
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 1, 2019

After merging this, I think we should release another alpha so people have time to test this user-facing change more widely.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 1, 2019

Thanks! Should we wait for #6445? I have a bit more work to do on it tomorrow morning.

@blink1073 blink1073 merged commit 6978027 into jupyterlab:master Jun 1, 2019
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 2, 2019

Should we wait for #6445? I have a bit more work to do on it tomorrow morning.

Sounds good to me.

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 2, 2019

Thanks! Should we wait for #6445? I have a bit more work to do on it tomorrow morning.

@blink1073 - can you do the release, then?

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 2, 2019

I'm trying to automate myself out of the role of release manager; it is too stressful for me.

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants