Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG namespace. Fixes #6295. #6469

Merged
merged 3 commits into from Jun 6, 2019
Merged

SVG namespace. Fixes #6295. #6469

merged 3 commits into from Jun 6, 2019

Conversation

@zerline
Copy link
Contributor

@zerline zerline commented Jun 4, 2019

References

Fixes #6295

Code changes

Add xmlns attribute to the svg tag if it not yet present.

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 4, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@@ -418,6 +418,12 @@ export function renderSVG(options: renderSVG.IRenderOptions): Promise<void> {
return Promise.resolve(undefined);
}

// Add missing SVG namespace (if actually missing)
var patt = '<svg[^>]+xmlns=[^>]+svg';
Copy link
Member

@blink1073 blink1073 Jun 4, 2019

Can you please change this to const patt? The lint checker is failing on this line.

@blink1073 blink1073 added this to the 1.0 milestone Jun 4, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 6, 2019

Looks like the test failure is not related to this PR. Thanks!

@jasongrout jasongrout merged commit ebadf8e into jupyterlab:master Jun 6, 2019
7 of 9 checks passed
@zerline zerline deleted the issue#6295 branch Jun 6, 2019
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants