Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifies workflow to export as Reveal.js slides #6472

Merged
merged 3 commits into from Jun 8, 2019

Conversation

duarteocarmo
Copy link
Member

@duarteocarmo duarteocarmo commented Jun 5, 2019

Closes #5018

References

This addresses issues #5018 and other exporting doubts that might come in the future.

Code changes

Added a new docs/source/user/export.rst file for future detailed explanations on exporting notebooks. (particularly how to export as .pdf)

Also added two screenshots to illustrate cases.

User-facing changes

A new section on the documentation pages:
Screen Shot 2019-06-05 at 14 45 48
Screen Shot 2019-06-05 at 14 45 36

Backwards-incompatible changes

None.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 5, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@duarteocarmo
Copy link
Member Author

@duarteocarmo duarteocarmo commented Jun 6, 2019

@jasongrout what do you think about this? To help out with #5018

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 6, 2019

Thanks! This list is built dynamically depending on what nbconvert offers, so maybe mentioning something about how they might have different options depending on their nbconvert configuration, but here are some common export options might make sense.

@blink1073 blink1073 added this to the 1.1 milestone Jun 6, 2019
@duarteocarmo
Copy link
Member Author

@duarteocarmo duarteocarmo commented Jun 7, 2019

@jasongrout adding that as we speak

@duarteocarmo
Copy link
Member Author

@duarteocarmo duarteocarmo commented Jun 7, 2019

@jasongrout and @blink1073 added nbconvert note.
Not sure why some of the integrations tests are failing tough.
Cmd.exe exited with code '1'.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 8, 2019

Thanks! The failure is unrelated.

@blink1073 blink1073 merged commit eafd1f9 into jupyterlab:master Jun 8, 2019
7 of 9 checks passed
@duarteocarmo
Copy link
Member Author

@duarteocarmo duarteocarmo commented Jun 8, 2019

@jasongrout and @blink1073 thanks for letting me contribute!

I wrote a blog post about the process if you’re interested 😅

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 9, 2019

Awesome, thank you for writing that up! Would you consider us making it a guest post on the Jupyter blog?

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 9, 2019

Also, I am curious as to what you think is needed to make Jupyterlab ready for prime time, as you say.

@duarteocarmo
Copy link
Member Author

@duarteocarmo duarteocarmo commented Jun 9, 2019

@blink1073 of course! Anything I should do?

@duarteocarmo
Copy link
Member Author

@duarteocarmo duarteocarmo commented Jun 9, 2019

Well, I think the project is very close, but a couple of things are still buggy (rendering, pdf conversion, themes, syntax), and a lot of the extension/add on ecosystem hasn’t migrated yet to jupyter lab.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 9, 2019

I'm not actually sure how the process works for guest posts, I'll find out and get back to you 😀. If you have specific bugs that you're seeing, please open some issues. 😉

@duarteocarmo
Copy link
Member Author

@duarteocarmo duarteocarmo commented Jun 9, 2019

Ok, that sounds good!

I’ll keep opening issues for whatever I see in the future.

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked label Aug 9, 2019
@jasongrout jasongrout removed this from the 1.1 milestone Aug 23, 2019
@jasongrout jasongrout added this to the 1.0 milestone Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants