Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using base_url in workspace name. #6473

Merged
merged 2 commits into from Jun 6, 2019

Conversation

@afshin
Copy link
Member

@afshin afshin commented Jun 5, 2019

References

Fixes #5977
Requires jupyterlab/jupyterlab_server#68

Code changes

Workspace names no longer include base_url.

User-facing changes

N/A

Backwards-incompatible changes

N/A

@afshin afshin added this to the 1.0 milestone Jun 5, 2019
@afshin afshin self-assigned this Jun 5, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 5, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 5, 2019

This is great @afshin! I was trying to remember the reason it was in the workspace ID to begin with -- are there any downsides to removing it?

@afshin
Copy link
Member Author

@afshin afshin commented Jun 5, 2019

@ian-r-rose Yes, I think there is this downside, if you:

  1. Launch JupyterLab with the default base_url and use it for a while.
  2. Launch JupyterLab with a different base_url. Your workspaces may now collide whereas they were safe before.

This means if you want to change base_url you should probably change workspaces_dir as well, unless you truly don't care.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 5, 2019

Ping @yuvipanda, do you see the base_url swapping as a problem for any deployments?

@yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Jun 5, 2019

What happens when they do clash? Do you just lose your workspace, or does JupyterLab just not work anymore?

@afshin
Copy link
Member Author

@afshin afshin commented Jun 5, 2019

If they clash you'll load the pre-existing workspace and any changes you make will clobber it and overwrite it.

It should not be a catastrophic failure and any files that don't exist in the old paths will fail silently, typically.

@yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Jun 5, 2019

That sounds good to me, @afshin

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 5, 2019

I have always viewed workspaces as pretty disposable, unless they are distributed as part of a demo repository, in which case they are in version control, so potential clobbering is okay.

@afshin
Copy link
Member Author

@afshin afshin commented Jun 5, 2019

I don't understand the Linux Usage failure of this build. Any ideas what might be happening?

@afshin afshin force-pushed the workspaces-base_url branch from 2a3f37b to 77a7466 Jun 6, 2019
@afshin afshin closed this Jun 6, 2019
@afshin afshin force-pushed the workspaces-base_url branch from 77a7466 to eedff54 Jun 6, 2019
@afshin afshin reopened this Jun 6, 2019
@afshin afshin force-pushed the workspaces-base_url branch from 44989c0 to 0cbfc4b Jun 6, 2019
Copy link
Member

@blink1073 blink1073 left a comment

NOiCe

@blink1073 blink1073 merged commit f8be765 into jupyterlab:master Jun 6, 2019
9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants