Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change keyboard shortcut for 'Close Tab' to 'Alt+W' from 'Accel+W'. #6486

Merged
merged 1 commit into from Jun 6, 2019

Conversation

@cquah
Copy link
Contributor

@cquah cquah commented Jun 6, 2019

References

Fixes #6357.

Code changes

This changes the keyboard shortcut for the 'Close Tab' command to 'Alt+W' from 'Accel+W'. On Windows and MacOS 10.14, 'Accel+W' closes the whole browser tab for several browsers. Per the discussion in #6357 , the 'Alt+W' shortcut looks like it is available and will not conflict with any browser shortcuts.

User-facing changes

Before:
Screen Shot 2019-06-06 at 2 08 04 PM

After:
Screen Shot 2019-06-06 at 2 18 20 PM

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 6, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 6, 2019

Looks like unrelated async test failures. I restarted the failed tests.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 6, 2019

Thanks again!

@blink1073 blink1073 merged commit 5058828 into jupyterlab:master Jun 6, 2019
9 checks passed
@blink1073 blink1073 added this to the 1.0 milestone Jun 6, 2019
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants