Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the DefaultSession own (create and dispose) its kernel connection. #6503

Merged
merged 1 commit into from Jun 8, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 7, 2019

References

Fixes #6142

Code changes

Before, a kernel was handed to the session, so it was confusing who was responsible for disposing the kernel connection. Now the API is changed so that the DefaultSession creates the kernel connection, so it is responsible for disposing it.

User-facing changes

None

Backwards-incompatible changes

The DefaultSession constructor now takes a kernel model, not a kernel connection.

Fixes jupyterlab#6142

Before, a kernel was handed to the session, so it was confusing who was responsible for disposing the kernel connection. Now the API is changed so that the DefaultSession creates the kernel connection, so it is responsible for disposing it.
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 7, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 1.0 milestone Jun 7, 2019
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 7, 2019

CC ibdafna

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 8, 2019

👍

@blink1073 blink1073 merged commit 244f6be into jupyterlab:master Jun 8, 2019
7 of 9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants