Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for changes to server #6509

Merged
merged 23 commits into from Jun 9, 2019
Merged

Update for changes to server #6509

merged 23 commits into from Jun 9, 2019

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 8, 2019

References

Fixes #6508
Relies on jupyterlab/jupyterlab_server#70 and a release.

Code changes

Updates some of the url names to match the ones used in the server.
We now have access to fully qualified versions of all urls as full-

User-facing changes

None. I verified mathjax output and delayed bundle loading in the main app and the example.

Backwards-incompatible changes

Two of the application url names have changed. pageUrl -> appUrl and publicUrl -> staticUrl.

@blink1073 blink1073 added this to the 1.0 milestone Jun 8, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 8, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

afshin
afshin approved these changes Jun 9, 2019
Copy link
Member

@afshin afshin left a comment

This looks ready once the jupyterlab_server version is bumped.

👍

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 9, 2019

@jasongrout, I removed the --no-bail option because it has been impossible to debug the output on azure. It has a limited scrollback and the log download doesn't work very well.

@blink1073 blink1073 merged commit 6b2e293 into jupyterlab:master Jun 9, 2019
9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@blink1073 blink1073 deleted the url-cleanup branch Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants