Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dialog.prompt (use InputDialog.getXXX instead) #6522

Merged
merged 5 commits into from Jun 11, 2019

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented Jun 10, 2019

References

Fixes #6378

Code changes

Remove Dialog.prompt in favor of InputDialog.getBoolean/getItem/getNumber/getText.
Removing Dialog.prompt will allow to use different options in the future depending of the input type; like specifying a min and a max values for number.

Nota:

  • I change the API to integrate the getXXX methods within InputDialog namespace to ease and clarify the API.
  • To match Dialog.prompt behavior, in the constructor parameters, label is now optional but title is not.

User-facing changes

None

Backwards-incompatible changes

Remove Dialog.prompt - it was only used in the CSV viewer to change the current line.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 10, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 1.0 milestone Jun 10, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 10, 2019

Nice! I fixed a few typos. Thanks for working on this!

@jasongrout jasongrout force-pushed the fix-6378 branch 2 times, most recently from 861fd9d to ba60b74 Jun 10, 2019
@jasongrout jasongrout merged commit 652a097 into jupyterlab:master Jun 11, 2019
9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants