Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Usage Cleanup #6533

Merged
merged 19 commits into from Jun 11, 2019
Merged

CSS Usage Cleanup #6533

merged 19 commits into from Jun 11, 2019

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 11, 2019

References

Fixes #6530

Code changes

Templates style/index.css based on dependencies that have style fields, in dependency order
Adds extraStyles metadata in package.json for additional external style imports.
Ignore the temporary imports.css file when building core mode.

User-facing changes

Frees the developer from maintaining the style index in most cases, with some manual
intervention for additional imports and imports to skip.
Adds developer docs for the new process.

Backwards-incompatible changes

None

@blink1073 blink1073 added this to the 1.0 milestone Jun 11, 2019
@blink1073 blink1073 changed the title CSS Usage Cleanup [WIP] CSS Usage Cleanup Jun 11, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 11, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

yarn.lock Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 11, 2019

The logic is almost done. I am going to defer the examples for after the RC.
Note to self:
We can't reuse the graph for build because it relies on local paths
We should add private data to graph to avoid reading the package.json files twice

@blink1073 blink1073 changed the title [WIP] CSS Usage Cleanup CSS Usage Cleanup Jun 11, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 11, 2019

@blink1073 - Ready for review?

Looks like the doc failure is unrelated - a link to binderhub down.

Copy link
Member

@saulshanabrook saulshanabrook left a comment

Works for me locally.

@saulshanabrook saulshanabrook merged commit 03a3c01 into jupyterlab:master Jun 11, 2019
9 checks passed
const skip = SKIP_CSS[name] || [];
const cssData: Dict<Array<string>> = {};

if (data.jupyter && data.jupyter.extraStyles) {
Copy link
Member

@vidartf vidartf Jun 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be data.jupyterlab? I see there are some extra styles missing somewhere (codemirror / xterm), while others are included (blueprint).

Copy link
Contributor

@jasongrout jasongrout Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right.

Copy link
Contributor

@jasongrout jasongrout Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #6541

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@blink1073 blink1073 deleted the fix-css-order branch Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants