Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add home tooltip showing server root if available for user information. #6552

Merged
merged 2 commits into from Jun 12, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 12, 2019

References

Addresses #6539 (comment) (i.e., #6207 (comment) )

Code changes

User-facing changes

Hovering over the home icon shows the server root, if available in page config.

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 12, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

packages/filebrowser/src/crumbs.ts Outdated Show resolved Hide resolved
afshin
afshin approved these changes Jun 12, 2019
Copy link
Member

@afshin afshin left a comment

Cheers!

👍

@jasongrout jasongrout merged commit 266a520 into jupyterlab:master Jun 12, 2019
6 of 9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants