Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab config urls #6585

Merged
merged 3 commits into from Jun 15, 2019
Merged

Lab config urls #6585

merged 3 commits into from Jun 15, 2019

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 14, 2019

References

Fixes #6584. #5977

Thanks to @ankostis for bringing this to my attention.

Code changes

Update config from page_url to app_url.
Removes temporary jupyterlab_server shim.

User-facing changes

Workspaces CLI works again.

Backwards-incompatible changes

None

@ian-r-rose ian-r-rose added this to the 1.0 milestone Jun 14, 2019
@ian-r-rose ian-r-rose requested a review from afshin Jun 14, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 14, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 14, 2019

@jasongrout jasongrout merged commit b386dfb into jupyterlab:master Jun 15, 2019
9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants