Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to a MainAreaWidget should propagate to the content #6586

Merged
merged 1 commit into from Jun 15, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 14, 2019

References

Fixes #6571

Code changes

Propagates MainAreaWidget update messages to the content as a convenience.

We already mirror title attributes, etc., to try to make the MainAreaWidget a transparent wrapper around the content in some ways. An update message is a common message, so mirroring that to the content makes sense.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 14, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 1.0 milestone Jun 14, 2019
Copy link
Member

@ian-r-rose ian-r-rose left a comment

Looks good to me, pending CI.

@jasongrout jasongrout force-pushed the mainwidgetupdate branch from ad2d796 to 9c22b50 Jun 14, 2019
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 14, 2019

Looks good to me, pending CI.

Note that I changed it to immediately propagate via sendMessage, instead of calling .update(), to make sure the semantics of calling the main area widget update were the same as calling the child widget update.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 14, 2019

Also seems reasonable, though I don't think we make any guarantees as to when an update message will get processed, so I think it was okay before as well.

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 15, 2019

Looks like linux js passed, windows has some async issues in unrelated tests.

@jasongrout jasongrout merged commit 9fd2a6d into jupyterlab:master Jun 15, 2019
9 of 10 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants