Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle the launcher, enable keyboard navigation #6587

Merged
merged 3 commits into from Jun 15, 2019

Conversation

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 15, 2019

References

Partial fix for #3795 intended for 1.0. A more ambitious improvement is being done in #5953.

See #6529 for full details. This PR supersedes that one.

Code changes

  • Each launcher card now has a valid tabindex and pressing enter when a card is focused will call onclick to open the activity. This enables keyboard interaction with the launcher.
  • The title of the card is now the kernel name if it is a notebook or console.

User-facing changes

  • Name of kernel now wraps to 2 lines to make longer kernel names visible.
  • Additional styling for active and focus states of cards.

Screen Shot 2019-06-10 at 3 07 06 PM

More examples:

Screen Shot 2019-06-10 at 3 09 36 PM

Backwards-incompatible changes

None.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 15, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 1.0 milestone Jun 15, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 15, 2019

Of course, I just happen to have 166 kernels :). I bumped the tab index step to 300 for a bit more room.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 15, 2019

actually, from https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex

If multiple elements share the same positive tabindex value, their order relative to each other follows their position in the document source.

So I just changed them all to have tabindex 100.

from https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex :

If multiple elements share the same positive tabindex value, their order relative to each other follows their position in the document source.
@jasongrout jasongrout changed the title Replacement for PR #6529 Restyle the launcher, enable keyboard navigation Jun 15, 2019
@jasongrout jasongrout merged commit 54dc755 into jupyterlab:master Jun 15, 2019
9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants