Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove settings table view #6646

Merged
merged 2 commits into from Jun 19, 2019
Merged

Conversation

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 19, 2019

References

Closes #6642
Partially addresses #6623

Code changes

Removes the table settings editor widget and all references to it

User-facing changes

There is no longer a "Table View" of the settings. The tab to switch between the table and raw view has been removed and the plugin list takes its space.

Screen Shot 2019-06-19 at 10 27 18 AM

Backwards-incompatible changes

The settings editor widget API has changed to remove tracking whether the user has selected the raw or table view

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 19, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@saulshanabrook saulshanabrook added this to the 1.0 milestone Jun 19, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 19, 2019

Nice! Looks good. Thanks!

@jasongrout jasongrout merged commit 659858d into jupyterlab:master Jun 19, 2019
9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants