Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the settings editor bug icon and always display the error inspector #6653

Merged
merged 2 commits into from Jun 20, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 19, 2019

References

Fixes #6623

Code changes

User-facing changes

Removes the bug icon in the settings editor and always displays the error messages.
Screen Shot 2019-06-19 at 3 56 08 PM

Backwards-incompatible changes

Removes some commands and accessors dealing with hiding/showing the debug messages.

@jasongrout jasongrout added this to the 1.0 milestone Jun 19, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 19, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@afshin
Copy link
Member

@afshin afshin commented Jun 20, 2019

The command settingeditor:debug also has a keyboard shortcut in plugin.json. Otherwise, this looks good to me!

afshin
afshin approved these changes Jun 20, 2019
Copy link
Member

@afshin afshin left a comment

👍

@afshin
Copy link
Member

@afshin afshin commented Jun 20, 2019

I really liked that we had an excuse to use that cute little bug 🐞 icon, but the greater good ...

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 20, 2019

I really liked that we had an excuse to use that cute little bug 🐞 icon, but the greater good ...

https://www.youtube.com/watch?v=yUpbOliTHJY

@afshin afshin merged commit a00ded1 into jupyterlab:master Jun 20, 2019
9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants