Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon cleanup #6664

Merged
merged 21 commits into from Jun 20, 2019
Merged

Icon cleanup #6664

merged 21 commits into from Jun 20, 2019

Conversation

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 20, 2019

This tackles a number of minor bugs and issues with our icons:

  • Naming consistency (CSS classes, CSS variables).
  • Color inconsistencies in light/dark theme.
  • Updates some icons to Material Design versions.
  • Added more "selected" versions of icons.
  • Make sure all extensions are using the latest versions.

References

Fixes #6621 and #6624

Replaces #6655

User-facing changes

Light:

Screen Shot 2019-06-20 at 1 05 40 PM

Dark:

Screen Shot 2019-06-20 at 1 05 52 PM

Backwards-incompatible changes

A number of CSS variables for icons have changed names.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 20, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 20, 2019

Hey, cool new kernel icon!

@saulshanabrook saulshanabrook self-requested a review Jun 20, 2019
Copy link
Member

@saulshanabrook saulshanabrook left a comment

Looks good for me locally

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 20, 2019

The test failure is a link to a Jupyter blog post that seems to be an inconsistent network error

@saulshanabrook saulshanabrook merged commit e6fee48 into jupyterlab:master Jun 20, 2019
7 of 9 checks passed
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants