Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support yarn configs with plain workspaces lists. #6689

Merged
merged 1 commit into from Jun 22, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 22, 2019

This is so that other projects can use buildutils even if they don’t use the nohoists format for their yarn workspace config.

References

This was updated in #6591.

Code changes

Other projects sometimes would like to use buildutils (for example, I use the update-dependency script to update things in ipywidgets), so understanding both versions of the yarn workspaces format is very useful.

User-facing changes

Backwards-incompatible changes

This is so that other projects can use buildutils even if they don’t use the nohoists format for their yarn workspace config.
@jasongrout jasongrout added this to the 1.0 milestone Jun 22, 2019
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 22, 2019

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jun 22, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 22, 2019

Thanks!

@blink1073 blink1073 merged commit 102dca5 into jupyterlab:master Jun 22, 2019
9 checks passed
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 22, 2019

I might make a patch release here so that people can use the update-dependencies script to easily update their extensions.

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 24, 2019

Thanks @jasongrout!

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants